Closed
Bug 1498608
Opened 7 years ago
Closed 7 years ago
Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox-esr60 fixed, firefox64 fixed)
RESOLVED
FIXED
mozilla64
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-esr60+
|
Details | Review |
This is generated code.
|
Assignee | |
Comment 1•7 years ago
|
||
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a471f6347154
Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r=andi
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9016679 [details]
Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r?andi
[ESR Uplift Approval Request]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.
User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.
Fix Landed on Version: 64
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.
String or UUID changes made by this patch: None
Attachment #9016679 -
Flags: approval-mozilla-esr60?
|
||
Updated•6 years ago
|
status-firefox-esr60:
--- → affected
|
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9016679 [details]
Bug 1498608 - Add js/src/builtin/intl/TimeZoneDataGenerated.h to .clang-format-ignore r?andi
OK for uplift to ESR60 as part of the clang-format project.
Attachment #9016679 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
|
|
||
Comment 6•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•